Migrate from Java 11 to Java 17 - #1072
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: sophia.lyssy <sophia.lyssy@windsurf.com>
Co-Authored-By: sophia.lyssy <sophia.lyssy@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targets Java 17:
sourceCompatibility/targetCompatibility'11'→'17'inbuild.gradle, README requirement updated.Compatibility audit (no bumps needed): Gradle wrapper 7.4 (17 supported since 7.3), Spring Boot 2.6.3, Lombok 1.18.22 (Boot-managed), DGS codegen 5.0.6.
One Java 17 issue surfaced: Spotless 6.2.1's google-java-format fails on JDK 17 with
IllegalAccessError ... module jdk.compiler does not export com.sun.tools.javac.parser(also withgoogleJavaFormat('1.17.0')). Fixed by addinggradle.propertieswithorg.gradle.jvmargs=--add-exports=jdk.compiler/com.sun.tools.javac.{api,file,parser,tree,util}=ALL-UNNAMED.DefaultJwtServiceTestwas reformatted to satisfyspotlessJavaCheck.Verified:
JAVA_HOME=<jdk17> ./gradlew clean build→ BUILD SUCCESSFUL, 68 tests, 0 failures.Note:
.github/workflows/gradle.ymlno longer exists on master (removed in #411), so there is no CI JDK step to update.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/d90064582e4b4f90a726cea0989b432a
Open in Devin Desktop: https://app.devin.ai/desktop/session/d90064582e4b4f90a726cea0989b432a?variant=devin
Requested by: @sophialyssy-demo
Note
Devin errored when opening this Pull Request as sophialyssy-demo.
As a fallback, Devin opened this PR as itself.